Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine+ui): Improve error messages [1/N] #353

Merged
merged 5 commits into from
Aug 24, 2024

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Aug 24, 2024

Makes progress on #307

Features

  • Add typing for TracecatException detail
  • Fix loguru KeyError: 'type' when passing f-strings with curly braces. This is a known loguru limitation based on how it handles string formatting/interpolation
  • Update workflow runs UI to be more consistent with rest of UI
  • Add toggle collapse for json viewer
  • Separate out error.message and error.stack_trace in the UI for better readability

Screens

Screen.Recording.2024-08-24.at.16.25.42.mov

@github-actions github-actions bot added engine Improvements or additions to the workflow engine enhancement New feature or request frontend Improvements or additions to the frontend labels Aug 24, 2024
@daryllimyt daryllimyt requested a review from topher-lo August 24, 2024 15:27
@daryllimyt daryllimyt self-assigned this Aug 24, 2024
@topher-lo topher-lo merged commit abd5ff4 into main Aug 24, 2024
7 checks passed
@topher-lo topher-lo deleted the feat/improve-workflow-run-error-messages-1 branch August 24, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Improvements or additions to the workflow engine enhancement New feature or request frontend Improvements or additions to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants