Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine+ui): Improve error messages [2/N] #355

Merged
merged 15 commits into from
Aug 25, 2024

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Aug 25, 2024

Makes progress on #307

Features

  • Add a "locator" of the form [ACTIONS.<action.ref> -> <location>] to error and validation messages. e.g. [ACTIONS. my_action -> run_if] <some error about run_if statement>
  • Clean up parser error messages
    • Avoid showing too low-level information like allowed terminals

Changes

See commit messages

New screens

Screenshot 2024-08-25 at 22 40 58 Screenshot 2024-08-25 at 22 41 32

Old Screens

  • The locator notation is outdated in the following screenshots
Screenshot 2024-08-25 at 20 59 08 Screenshot 2024-08-25 at 21 46 53 Screenshot 2024-08-25 at 18 23 05 Screenshot 2024-08-25 at 18 58 54

@daryllimyt daryllimyt requested a review from topher-lo August 25, 2024 20:45
@daryllimyt daryllimyt self-assigned this Aug 25, 2024
@github-actions github-actions bot added engine Improvements or additions to the workflow engine enhancement New feature or request frontend Improvements or additions to the frontend labels Aug 25, 2024
@topher-lo topher-lo merged commit 44b99e0 into main Aug 25, 2024
10 checks passed
@topher-lo topher-lo deleted the feat/improve-error-messages-2 branch August 25, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Improvements or additions to the workflow engine enhancement New feature or request frontend Improvements or additions to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants