-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat+fix(engine)!: Support enums and defaults in Action Templates #644
Open
topher-lo
wants to merge
33
commits into
main
Choose a base branch
from
feat/enum-action-templates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+401
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes missing defaults and no input validation on run.
…ts (optional fields with None as default value)
topher-lo
added
engine
Improvements or additions to the workflow engine
breaking
Breaking changes
labels
Dec 21, 2024
daryllimyt
requested changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor change
Signed-off-by: Chris Lo <[email protected]>
daryllimyt
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
validate_args
method to returnmodel_schema_inputs
with json mode (i.e. enum instances are coerced into string)validate
conditional in_run_action_direct
(this path isn't used anywhere in the code)tracecat_registry._internal.exceptions.TracecatValidationError
withtracecat.types.exceptions.TracecatValidationError
Note: we had to make
key
inTracecatValidationError
optional and serializable in order to bypass Ray's issue reraising instances of exceptions. ray-project/ray#8948. Unsure why but unless all init variables for the exception are optional, ray seems to keep raising theTypeError
with missingkey
. See reference for example.References