Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine): Support Temporal API key and MTLS from AWS SM #648

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(engine): Support Temporal API key and MTLS from AWS SM #648

wants to merge 6 commits into from
+322 −118

Conversation

topher-lo
Copy link
Contributor

@topher-lo topher-lo commented Dec 21, 2024 •
edited
Loading

What changed

  • Now supports both API key or MTLS client certs for authenticating a temporal client to temporal cloud server
  • Added relevant terraform variables and made temporal server optional (but on by default) for Fargate

@topher-lo topher-lo added enhancement New feature or request engine Improvements or additions to the workflow engine infrastructure Infra updates and fixes labels Dec 21, 2024
@topher-lo topher-lo changed the title feat(engine): Support Temporal MTLS client certs feat(engine): Support Temporal API key and MTLS from AWS secrets manager Dec 21, 2024
@topher-lo topher-lo changed the title feat(engine): Support Temporal API key and MTLS from AWS secrets manager feat(engine): Support Temporal API key and MTLS from AWS SM Dec 21, 2024
@topher-lo topher-lo requested a review from daryllimyt December 22, 2024 02:01
daryllimyt
daryllimyt approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@daryllimyt daryllimyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor optional edit

tracecat/config.py
TEMPORAL__TLS_CLIENT_PRIVATE_KEY = os.environ.get("TEMPORAL__TLS_CLIENT_PRIVATE_KEY")
)
TEMPORAL__API_KEY__ARN = os.environ.get("TEMPORAL__API_KEY__ARN")
TEMPORAL__MTLS_ENABLED = os.environ.get("TEMPORAL__MTLS_ENABLED", False) == "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to ignore

Suggested change
TEMPORAL__MTLS_ENABLED = os.environ.get("TEMPORAL__MTLS_ENABLED", False) == "true"
TEMPORAL__MTLS_ENABLED = os.environ.get("TEMPORAL__MTLS_ENABLED", "").lower() in ("1", "true")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daryllimyt daryllimyt daryllimyt approved these changes

Assignees
No one assigned
Labels
engine Improvements or additions to the workflow engine enhancement New feature or request infrastructure Infra updates and fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topher-lo @daryllimyt