-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve information for transaction status #263
Merged
mastudillot
merged 19 commits into
develop
from
feat/improve-information-for-transaction-status
Nov 13, 2024
Merged
feat: improve information for transaction status #263
mastudillot
merged 19 commits into
develop
from
feat/improve-information-for-transaction-status
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
mastudillot
requested review from
mvarlic,
victormendoza96,
DiegoHBustamante and
Matiasnickolas
November 13, 2024 19:14
mvarlic
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
victormendoza96
approved these changes
Nov 13, 2024
Matiasnickolas
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ
mastudillot
deleted the
feat/improve-information-for-transaction-status
branch
November 13, 2024 20:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the way transaction status data is displayed. The detail is:
Note:
The colors in the status were added so that the transaction can always be consulted in the future, if possible, not only when it is approved.
Tests
Authorized transaction
Refunded transaction
Error getting status