Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve information for transaction status #263

Merged
merged 19 commits into from
Nov 13, 2024

Conversation

mastudillot
Copy link
Member

@mastudillot mastudillot commented Nov 13, 2024

This PR improves the way transaction status data is displayed. The detail is:

  • Improve messages to users.
  • Add formatting to fields.
  • Add logs to the controller to obtain the status of the transaction.
  • Improves error control.

Note:
The colors in the status were added so that the transaction can always be consulted in the future, if possible, not only when it is approved.

Tests

Authorized transaction

image

Refunded transaction

imageimage

Error getting status

imageimage

@mastudillot mastudillot self-assigned this Nov 13, 2024
Copy link

sonarcloud bot commented Nov 13, 2024

plugin/js/admin.js Show resolved Hide resolved
plugin/js/admin.js Show resolved Hide resolved
Copy link
Contributor

@mvarlic mvarlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Matiasnickolas Matiasnickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

@mastudillot mastudillot merged commit 1c1c5bd into develop Nov 13, 2024
4 checks passed
@mastudillot mastudillot deleted the feat/improve-information-for-transaction-status branch November 13, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants