Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove default environment configuration #103

Merged
merged 24 commits into from
Aug 28, 2024

Conversation

mvarlic
Copy link
Contributor

@mvarlic mvarlic commented Aug 26, 2024

This PR removes the default configuration for integration environment on all products.
Now is necessary use a build method for integration or production environment to create an object.
This is a breaking change, now the integrator must always have control of the environment in which they will use the product, using the corresponding method and credentials.

For example, to create a Webpay Plus Transaction now you must call their corresponding build method.

Integration:
let transaction = WebpayPlus.Transaction
.buildForIntegration("integrationCommerceCode", "integrationApiKey");

Production:
let transaction = WebpayPlus.Transaction
.buildForProduction("productionCommerceCode", "productionApiKey");

image

Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Aug 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
31.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvarlic mvarlic merged commit 4e8618e into develop Aug 28, 2024
4 of 5 checks passed
@mvarlic mvarlic deleted the feat/remove-default-configuration branch August 28, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants