Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: kiuwan alerts #106

Merged
merged 12 commits into from
Oct 21, 2024
Merged

refactor: kiuwan alerts #106

merged 12 commits into from
Oct 21, 2024

Conversation

mvarlic
Copy link
Contributor

@mvarlic mvarlic commented Oct 21, 2024

this PR:

  • refactored by kiuwan's request
  • kiuwan alerts fixed

image

Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
42.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Matiasnickolas Matiasnickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

@mvarlic mvarlic merged commit 09659b1 into develop Oct 21, 2024
4 of 5 checks passed
@mvarlic mvarlic deleted the refactor/kiuwan-alerts branch October 21, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants