Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: downgrade api 1.3 to 1.2 #78

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

tribiec
Copy link
Contributor

@tribiec tribiec commented Jan 3, 2024

This PR downgrades the API version from 1.3 to 1.2 and also removes some specific methods used on version 1.3.

@tribiec tribiec changed the title draft: downgrade api 1.3 to 1.2 downgrade api 1.3 to 1.2 Jan 3, 2024
mastudillot

This comment was marked as outdated.

@Matiasnickolas
Copy link

Commits should use a short lead token, like refactor, feat, etc.
Modifications to changelog should be added on the prepare release branch

@tribiec tribiec force-pushed the feat/downgrade-api-to-1.2 branch from 86c1df9 to 625716f Compare January 4, 2024 15:43
@tribiec tribiec self-assigned this Jan 4, 2024
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastudillot mastudillot changed the title downgrade api 1.3 to 1.2 feat: downgrade api 1.3 to 1.2 Jan 5, 2024
Copy link
Contributor

@mvarlic mvarlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tribiec tribiec merged commit 8ebe1cd into master Jan 8, 2024
7 checks passed
@tribiec tribiec deleted the feat/downgrade-api-to-1.2 branch January 8, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants