Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix publish job #93

Merged
merged 3 commits into from
Feb 2, 2024
Merged

chore: fix publish job #93

merged 3 commits into from
Feb 2, 2024

Conversation

tribiec
Copy link
Contributor

@tribiec tribiec commented Feb 2, 2024

This pull request separates the build-and-publish step from the build.yml file to a new npm_package.yml file. This enables better control over the automatic build and publish conditions of an npm_package when a new tag is generated on the master branch.

Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tribiec tribiec merged commit cbe24e0 into master Feb 2, 2024
5 checks passed
@tribiec tribiec deleted the chore/fix-publish-job branch February 2, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants