Merged
Conversation
…nsactions into discrete time-windowed graph snapshots for training
|
@soma-enyi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69
feat: Standard 2-layer Graph Convolutional Network using PyG for node classification
Problem
The existing GCN class was a configurable N-layer model that accepted a hidden_dims list. While flexible, it didn't
match the standard 2-layer GCN architecture from Kipf & Welling (2017) — the
canonical baseline for node classification benchmarks. The training script also had no validation loop, making it
impossible to track generalisation during training.
Changes
astroml/models/gcn.py
Replaced the N-layer implementation with a strict 2-layer GCN:
Input → GCNConv(input_dim, hidden_dim) → ReLU → Dropout → GCNConv(hidden_dim, output_dim) → log_softmax
astroml/training/train_gcn.py
Before / After
Before:
python
GCN(input_dim=..., hidden_dims=[64], output_dim=..., dropout=0.5)
After:
python
GCN(input_dim=..., hidden_dim=16, output_dim=..., dropout=0.5)
Training output now looks like:
Epoch 20 | Loss: 1.2341 | Val Acc: 0.7100
Epoch 40 | Loss: 0.9823 | Val Acc: 0.7560
...
Test Accuracy: 0.8120
Related
Closes #[69] — Standard 2-layer Graph Convolutional Network using PyG for node classification