Add memory properties and make it accessible for Vulkan allocation #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manon-traverse
approved these changes
Nov 10, 2022
MarijnS95
approved these changes
Nov 11, 2022
|
Yeah, I came across this while trying to use/implement resizable BAR. Checking for all those flags is needed to identify if you need to flush and whether the memory is DeviceLocal. |
Co-authored-by: Marijn Suijten <[email protected]>
SiebenCorgie
force-pushed
the
feature-expose-memory-properties
branch
from
7849957
to
9daa4d6
Compare
|
Is anything missing for it to be merged? I force-pushed a small update for the PR to not conflict with |
MarijnS95
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request exposes the
vk::MemoryPropertyFlagsof anAllocationvia thememory_propertiesfunction.The reason for the request is, that I was not able to obtain the flags on the current release. If it is possible and i just did not find it, please close the request.
I need the flags when checking what the properties of an allocation using the
MemoryLocation::CpuToGpurequirement are. Specifically, it is interesting if it contains theDEVICE_LOCALbit or not. Depending on this code the outcome can be different.If there is anything you'd like me to add, please let me know!