Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visualization: Replace custom event conversion with imgui-winit-support #29

Merged
merged 1 commit into from
Oct 3, 2021
Merged

visualization: Replace custom event conversion with imgui-winit-support #29

merged 1 commit into from
Oct 3, 2021

Conversation

MarijnS95
Copy link
Member

@MarijnS95 MarijnS95 commented May 25, 2021 •
edited
Loading

Depends on #27 and #28

@MarijnS95
Copy link
Member Author

@max-traverse We should apply #29 and this to the DX12 visualizer as well, but since you plan on removing the duplication in #59 anyway we should probably keep these patches for Vulkan only and make sure to use the Vulkan visualizer as a base when unifying.

@MarijnS95 MarijnS95 mentioned this pull request Sep 19, 2021
Merged
@MarijnS95 MarijnS95 merged commit 4498abf into main Oct 3, 2021
@MarijnS95 MarijnS95 deleted the imgui-winit-support branch October 3, 2021 09:24
@MarijnS95 MarijnS95 mentioned this pull request Oct 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manon-traverse manon-traverse Awaiting requested review from manon-traverse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarijnS95