Skip to content

feat(icon): add rtl support to arrow icons #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2025
Merged

feat(icon): add rtl support to arrow icons #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b74eb10
fix(Alert): content width
gokselpirnal Sep 3, 2025
6097a1e
feat(icon): add rtl support to arrow icons
dilarakirn Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/Alert/Alert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import Icon from '../Icon/Icon';
import { IconNameType } from '../Icon/types';
import theme, { Theme } from '../../theme';
import { AlertIcon } from './AlertIcon';
import { deviceWidth } from '../../utils/dimentions';

type AlertProps = React.ComponentProps<typeof Box> & {
variant?: VariantProps<Theme, 'alertVariants'>['variant'];
Expand Down Expand Up @@ -51,7 +50,7 @@ const Alert = ({

return (
<AlertContainer variant={variant} {...rest}>
<Box p="m" flexDirection="row" width={deviceWidth - theme.spacing['2xl']}>
<Box p="m" flexDirection="row">
<Box pr="2xs">
<AlertIcon variant={variant} icon={icon} />
</Box>
Expand Down
1 change: 0 additions & 1 deletion src/components/Alert/__snapshots__/Alert.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ exports[`Alert should render alert correctly 1`] = `
{
"flexDirection": "row",
"padding": 16,
"width": 718,
},
]
}
Expand Down
Loading
Loading