This repository was archived by the owner on Feb 1, 2026. It is now read-only.
fix: 581 environment lightformers are not working#584
Merged
alvarosabu merged 5 commits intomainfrom Jan 17, 2025
Merged
Conversation
…date routing and environment handling - Enhanced environment handling in `useEnvironment` with improved texture management and disposal methods. - Refactored `EnvSence` class to use `dispose` method for better resource management. - Updated lightformer properties for consistency and improved functionality.
alvarosabu
added
bug
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
andretchen0
suggested changes
Jan 10, 2025
Contributor
andretchen0
left a comment
andretchen0
left a comment
There was a problem hiding this comment.
Works!
There's a memory leak to patch up or work around.
Contributor
There was a problem hiding this comment.
(non-blocking)
Since this PR is correcting typos, maybe it's time to rename this envScene?
… improved resource management and texture handling
…sting meshes and updating background properties to avoid memory leaks
andretchen0
approved these changes
Jan 17, 2025
alvarosabu
deleted the
bugfix/581-environment-lightformers-are-not-working
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #581
@hawk86104 you were close with the slots watcher, it was one of the reasons, I just improved a couple of things. It should work now
Screen.Recording.2025-01-08.at.17.24.55.mov