Skip to content

chore: upgraded playground to nuxt v3.16 in compat mode for nuxt 4 #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

justserdar
Copy link

Upgraded the module to the latest version of Nuxt (3.16) with compat mode for Nuxt 4.
Fixed some additional minor stuff in the module.ts file.

@justserdar justserdar requested a review from alvarosabu as a code owner March 14, 2025 21:57
@justserdar
Copy link
Author

Hey @colinscz , I +1'd it by updating it to the newest newest version of Nuxt, including the other packages.

Copy link

@colinscz colinscz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, @alvarosabu could you verify/approve/merge it?
In any case we probably have to test it again with a nuxt project after the merge to see if the other issues were also resolved which you mentioned in the discord some time ago last year.

@justserdar justserdar requested a review from alvarosabu April 3, 2025 13:16
@userquin
Copy link
Member

userquin commented Apr 3, 2025

the pnpm.* entries added by pnpm when you run pnpm approve-builds and selected the deps?

@userquin
Copy link
Member

userquin commented Apr 3, 2025

missing pnpm lock file: when updating to 10.7.0 or 10.7.1, pnpm should ask if recreating lock file and node_modules: press Y and when selected the deps after pnpm approve-builds press also Y

... and then, commit and push pnpm lock file

@justserdar
Copy link
Author

You are correct, It didn't produce or ask for a new one after updating to 10.7.1, weird.

  • pnpm i :: Done in 4.6s using pnpm v10.7.1
  • pnpm approve-builds :: There are no packages awaiting approval

Pushed the lock file!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants