docs: clean demos #189
Merged
docs: clean demos #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmontastier
added
documentation
Tinoooo
approved these changes
Mar 4, 2025
|
Thank you @damienmontastier for the cleanup! Very cool! Sorry for the late review. |
Tinoooo
pushed a commit
that referenced
this pull request
Mar 9, 2025
* fix: delete multisampling used in TresCanvas props * docs: clean demos (#189) * demos (>v2.0) cleaned and review * add suspense to introduction demo code * change language demo code, add highlights lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the usage demos in the documentation (those from version >V2.0) to improve readability. Although the demos have been streamlined, it was still essential to provide users with the complete source code. To achieve this, an expandable menu has been added below each demo, allowing users to view the demo's code.
I've also modified the demos in the documentation introduction. The tags were missing.
Are demos still too massive, or is that okay?
Because the imports can be removed, I just think it's important to keep
<TresPerspectiveCamera />to understand the level at which to activate<EffectComposerPmndrs />.I haven't modified @Tinoooo demos (before version 2.0), I may do so later when we've agreed on a “basic model” of demo usage style.
The branch is deliberately based on the fix/bad-use-multisampling branch. I also based the PR directly on the
bad-use-multisamplingbranch instead ofmain. I don't know if that's a good practice or not, you tell me!