feat(postprocessing): re-instance effect on prop changes without set #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add blend function support to OutlinePmndrs component - Implement dynamic effect recreation for specific prop changes - Update playground example with more interactive outline configuration - Add console logging for debugging and development purposes
…afety - Remove unused imports and console logs - Improve type annotation for OutlinePmndrs ref - Remove unnecessary gl configuration - Add eslint disable for console log in watchEffect
…ed effect recreation
…; updated Glitch component to utilize new functionality.
commit: |
alvarosabu
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
This looks way better @Tinoooo I tested the playground and the blend function in several examples and is working as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some substantial changes in #192. I couldn't set the reviewer to @alvarosabu, so I opened this new PR.