fix: node16 types #888

alvarosabu · 2024-12-20T16:39:56Z

Before:

After:

netlify · 2024-12-20T16:40:15Z

✅ Deploy Preview for tresjs-docs ready!

Name	Link
🔨 Latest commit	`a086ca1`
🔍 Latest deploy log	https://app.netlify.com/sites/tresjs-docs/deploys/67680126544a5c00080a1a79
😎 Deploy Preview	https://deploy-preview-888--tresjs-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pkg-pr-new · 2024-12-20T16:58:24Z

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/core@888

commit: a086ca1

userquin · 2024-12-20T20:13:03Z

check #889 and merge it here if it is fine for you

userquin · 2024-12-20T20:14:28Z

package.json

+  },
+  "pnpm": {
+    "overrides": {
+      "typescript": "5.7.2"


we don't need to pin the version, use ^5.7.2

ypu will need to run pnpm install the lock file should be updated

package.json

renovate.json

brc-dd · 2024-12-22T06:54:34Z

Try applying this diff (save it to foo.diff in repo and run git apply foo.diff):

diff --git a/netlify.toml b/netlify.toml
index 247247d..4d2e490 100644
--- a/netlify.toml
+++ b/netlify.toml
@@ -1,6 +1,6 @@
 [build]
 publish = "docs/.vitepress/dist"
-command = "pnpm run build && pnpm docs:build"
+command = "NODE_OPTIONS=--max-old-space-size=2048 pnpm run build && pnpm docs:build"
 
 [build.environment]
-NODE_VERSION = "18"
+NODE_VERSION = "22"
diff --git a/package.json b/package.json
index 35039ba..4ca324c 100644
--- a/package.json
+++ b/package.json
@@ -121,6 +121,9 @@
   "pnpm": {
     "overrides": {
       "typescript": "^5.7.2"
+    },
+    "patchedDependencies": {
+      "vite-plugin-dts": "patches/vite-plugin-dts.patch"
     }
   },
   "publishConfig": {
diff --git a/patches/vite-plugin-dts.patch b/patches/vite-plugin-dts.patch
new file mode 100644
index 0000000..2b020aa
--- /dev/null
+++ b/patches/vite-plugin-dts.patch
@@ -0,0 +1,17 @@
+diff --git a/dist/index.mjs b/dist/index.mjs
+index 3822cbc3bf4c271c6a82fe2729d8c5e15b657b0f..95892c08f197c45e6d0997f4ff71329ab6ce9041 100644
+--- a/dist/index.mjs
++++ b/dist/index.mjs
+@@ -58,10 +58,10 @@ async function runParallel(maxConcurrency, source, iteratorFn) {
+   for (const item of source) {
+     const p = Promise.resolve().then(() => iteratorFn(item, source));
+     ret.push(p);
+-    if (maxConcurrency <= source.length) {
++    if (1 <= source.length) {
+       const e = p.then(() => executing.splice(executing.indexOf(e), 1));
+       executing.push(e);
+-      if (executing.length >= maxConcurrency) {
++      if (executing.length >= 1) {
+         await Promise.race(executing);
+       }
+     }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index b3966a0..b8c4f7b 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -7,6 +7,11 @@ settings:
 overrides:
   typescript: ^5.7.2
 
+patchedDependencies:
+  vite-plugin-dts:
+    hash: kywozdv6i5i7n4adjtglj6xx5e
+    path: patches/vite-plugin-dts.patch
+
 importers:
 
   .:
@@ -35,7 +40,7 @@ importers:
         version: 4.0.3(@tresjs/[email protected]([email protected])([email protected]([email protected])))(@types/[email protected])([email protected])([email protected]([email protected]))
       '@tresjs/eslint-config':
         specifier: ^1.4.0
-        version: 1.4.0(@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))(@vue/[email protected])([email protected]([email protected]))([email protected])([email protected](@types/[email protected])(@vitest/[email protected])([email protected]))
+        version: 1.4.0(@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))(@vue/[email protected])([email protected]([email protected]))([email protected])([email protected])
       '@types/three':
         specifier: ^0.171.0
         version: 0.171.0
@@ -50,10 +55,10 @@ importers:
         version: 5.2.1([email protected](@types/[email protected])([email protected])([email protected])([email protected]))([email protected]([email protected]))
       '@vitest/coverage-c8':
         specifier: ^0.33.0
-        version: 0.33.0([email protected](@types/[email protected])(@vitest/[email protected])([email protected]))
+        version: 0.33.0([email protected])
       '@vitest/coverage-v8':
         specifier: ^2.1.8
-        version: 2.1.8([email protected](@types/[email protected])(@vitest/[email protected])([email protected]))
+        version: 2.1.8([email protected])
       '@vitest/ui':
         specifier: ^2.1.8
         version: 2.1.8([email protected])
@@ -122,7 +127,7 @@ importers:
         version: 0.8.0
       vite-plugin-dts:
         specifier: 4.4.0
-        version: 4.4.0(@types/[email protected])([email protected])([email protected])([email protected](@types/[email protected])([email protected])([email protected])([email protected]))
+        version: 4.4.0(patch_hash=kywozdv6i5i7n4adjtglj6xx5e)(@types/[email protected])([email protected])([email protected])([email protected](@types/[email protected])([email protected])([email protected])([email protected]))
       vite-plugin-inspect:
         specifier: ^0.10.4
         version: 0.10.4([email protected])([email protected](@types/[email protected])([email protected])([email protected])([email protected]))
@@ -5627,7 +5632,7 @@ snapshots:
 
   '@andrewbranch/[email protected]': {}
 
-  '@antfu/[email protected](@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))(@vue/[email protected])([email protected]([email protected]([email protected])))([email protected]([email protected]))([email protected])([email protected](@types/[email protected])(@vitest/[email protected])([email protected]))':
+  '@antfu/[email protected](@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))(@vue/[email protected])([email protected]([email protected]([email protected])))([email protected]([email protected]))([email protected])([email protected])':
     dependencies:
       '@antfu/install-pkg': 0.4.1
       '@clack/prompts': 0.7.0
@@ -5636,7 +5641,7 @@ snapshots:
       '@stylistic/eslint-plugin': 2.12.1([email protected]([email protected]))([email protected])
       '@typescript-eslint/eslint-plugin': 8.18.1(@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))([email protected]([email protected]))([email protected])
       '@typescript-eslint/parser': 8.18.1([email protected]([email protected]))([email protected])
-      '@vitest/eslint-plugin': 1.1.20(@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))([email protected]([email protected]))([email protected])([email protected](@types/[email protected])(@vitest/[email protected])([email protected]))
+      '@vitest/eslint-plugin': 1.1.20(@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))([email protected]([email protected]))([email protected])([email protected])
       eslint: 9.17.0([email protected])
       eslint-config-flat-gitignore: 0.3.0([email protected]([email protected]))
       eslint-flat-config-utils: 0.4.0
@@ -6810,9 +6815,9 @@ snapshots:
     transitivePeerDependencies:
       - '@vue/composition-api'
 
-  '@tresjs/[email protected](@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))(@vue/[email protected])([email protected]([email protected]))([email protected])([email protected](@types/[email protected])(@vitest/[email protected])([email protected]))':
+  '@tresjs/[email protected](@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))(@vue/[email protected])([email protected]([email protected]))([email protected])([email protected])':
     dependencies:
-      '@antfu/eslint-config': 3.6.2(@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))(@vue/[email protected])([email protected]([email protected]([email protected])))([email protected]([email protected]))([email protected])([email protected](@types/[email protected])(@vitest/[email protected])([email protected]))
+      '@antfu/eslint-config': 3.6.2(@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))(@vue/[email protected])([email protected]([email protected]([email protected])))([email protected]([email protected]))([email protected])([email protected])
       eslint: 9.17.0([email protected])
       eslint-plugin-format: 0.1.3([email protected]([email protected]))
     transitivePeerDependencies:
@@ -7179,7 +7184,7 @@ snapshots:
       vite: 6.0.5(@types/[email protected])([email protected])([email protected])([email protected])
       vue: 3.5.13([email protected])
 
-  '@vitest/[email protected]([email protected](@types/[email protected])(@vitest/[email protected])([email protected]))':
+  '@vitest/[email protected]([email protected])':
     dependencies:
       '@ampproject/remapping': 2.3.0
       c8: 7.14.0
@@ -7188,7 +7193,7 @@ snapshots:
       std-env: 3.8.0
       vitest: 2.1.8(@types/[email protected])(@vitest/[email protected])([email protected])
 
-  '@vitest/[email protected]([email protected](@types/[email protected])(@vitest/[email protected])([email protected]))':
+  '@vitest/[email protected]([email protected])':
     dependencies:
       '@ampproject/remapping': 2.3.0
       '@bcoe/v8-coverage': 0.2.3
@@ -7206,7 +7211,7 @@ snapshots:
     transitivePeerDependencies:
       - supports-color
 
-  '@vitest/[email protected](@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))([email protected]([email protected]))([email protected])([email protected](@types/[email protected])(@vitest/[email protected])([email protected]))':
+  '@vitest/[email protected](@typescript-eslint/[email protected]([email protected]([email protected]))([email protected]))([email protected]([email protected]))([email protected])([email protected])':
     dependencies:
       '@typescript-eslint/utils': 8.18.1([email protected]([email protected]))([email protected])
       eslint: 9.17.0([email protected])
@@ -10957,7 +10962,7 @@ snapshots:
     dependencies:
       vite: 6.0.5(@types/[email protected])([email protected])([email protected])([email protected])
 
-  [email protected](@types/[email protected])([email protected])([email protected])([email protected](@types/[email protected])([email protected])([email protected])([email protected])):
+  [email protected](patch_hash=kywozdv6i5i7n4adjtglj6xx5e)(@types/[email protected])([email protected])([email protected])([email protected](@types/[email protected])([email protected])([email protected])([email protected])):
     dependencies:
       '@microsoft/api-extractor': 7.48.1(@types/[email protected])
       '@rollup/pluginutils': 5.1.4([email protected])

alvarosabu · 2024-12-22T09:37:07Z

Hi @brc-dd thanks for jumping in!

I manually added the increased space size for Netlify but I have a question regarding the diff file you provided, whats the idea behind patching vite-plugin-dts?

"patchedDependencies": {
+      "vite-plugin-dts": "patches/vite-plugin-dts.patch"
     }

brc-dd · 2024-12-22T09:39:52Z

Ah, vite-plugin-dts is trying to run multiple instances of api-extractor concurrently (for each entry file) which are causing the memory issue. So with that patch I'm setting maxConcurrency to 1. With the patch the memory was not exceeding ~1.5GB locally for me (even without max-old-space-size).

You can probably make a PR to vite-plugin-dts to add an option to specify concurrency.

alvarosabu · 2024-12-22T09:48:21Z

Ohh @brc-dd thanks for clarifying, it's something that is going to be eventually merged on the vite-plugin-dts ? I would prefer not to have it patched for long time.

brc-dd · 2024-12-22T09:50:15Z

I mean you can try creating an issue/PR. The project is active. Ultimately, it's up to their maintainer. 😅

userquin

LGTM

Did yoy check this pr via pkg.pr.new in a reproduction?

alvarosabu · 2024-12-22T11:09:27Z

Did yoy check this pr via pkg.pr.new in a reproduction?

Mmm, something is no longer right, dynamic types for the Tres components no longer work. =(

brc-dd · 2024-12-22T11:20:44Z

TresComponents type is being stripped from output 👀

utils.d.ts is also broken

alvarosabu · 2024-12-22T11:23:59Z

Mmmm @brc-dd If I remove the multiple entries on vite.config.ts the types work again

 entry: {
        tres: resolve(__dirname, 'src/index.ts'),
        /* components: resolve(__dirname, 'src/components/index.ts'),
        composables: resolve(__dirname, 'src/composables/index.ts'),
        types: resolve(__dirname, 'src/types/index.ts'),
        utils: resolve(__dirname, 'src/utils/index.ts'), */
      },

brc-dd · 2024-12-22T11:25:30Z

Yeah I think this is a limitation of api-extractor. I remember seeing it in their docs that it only works if your project has single entrypoint. rollupTypes option might not work for you then 🫠

alvarosabu · 2024-12-22T11:30:26Z

Yeah I think this is a limitation of api-extractor. I remember seeing it in their docs that it only works if your project has single entrypoint. rollupTypes option might not work for you then 🫠

In that case @userquin I'm gonna remove the multiple entries and the submodules and change the target of this PR to the next branch to be included in the next major version in January. Users will need to live with broken types for node16 for a little bit longer.

userquin · 2024-12-22T11:39:55Z

Using only 1 entry works?

brc-dd · 2024-12-22T11:43:29Z

The utils.d.ts issue is because of imports like from 'src/types' -- these should be converted to relative imports. The ambient types issue is still there.

brc-dd · 2024-12-22T11:46:35Z

Quick question, does tres use something like triple slash reference to register global components? (similar to "vite/client" ?)

BREAKING CHANGE: import submodules like `@Tresjs/core/components` will no longer be possible. Use `@Tresjs/core` instead

alvarosabu · 2024-12-22T12:00:31Z

Quick question, does tres use something like triple slash reference to register global components? (similar to "vite/client"

No @brc-dd

Using only 1 entry works?

It works locally on the playground, but if I install it on a separate repo it seems like it doesnt @userquin

userquin · 2024-12-22T12:00:44Z

My original pr was also replacing all src/ imports to relative paths...

userquin · 2024-12-22T12:06:05Z

This is weird, iirc post processing was working, the package using 2 entries

brc-dd · 2024-12-22T12:07:15Z

No @brc-dd

Then how are they discovered? 👀

alvarosabu · 2024-12-22T12:11:21Z

Ok so by exporting all the types that where private before fix: export all types for TresComponents, which helps build the TresComponents global. They work again.

Maybe with the new approach, all composed types need to be explicitly exported? @userquin

Then how are they discovered? 👀

@brc-dd dunno how to answer that, they were just working with the export

brc-dd · 2024-12-22T12:17:35Z

hmm, I think they were working because when you import something from '@tresjs/core' it was registering the types because tres.d.ts is being imported. But this would've been flaky if someone is using a component without directly importing tres/core.

The correct way is to do this like vite/client and vitest/globals. There should be a separate ambient declaration file that declares all those components. And people will need to add triple slash references or configure tsConfig.compilerOptions.types array to make sure those components are available everywhere.

The nuxt module correctly pushes this - https://github.com/Tresjs/nuxt/blob/f19abcb040b3b8dc7adbdd6ac98d63d4ce57bd15/src/module.ts#L54

In vite too if you add that manually it was working fine with multiple entrypoints:

patch (git reset HEAD~2; git stash; git apply foo.diff):

diff --git a/src/composables/useRaycaster/index.ts b/src/composables/useRaycaster/index.ts
index da77950..ec2a369 100644
--- a/src/composables/useRaycaster/index.ts
+++ b/src/composables/useRaycaster/index.ts
@@ -1,5 +1,5 @@
 import type { EventHook } from '@vueuse/core'
-import type { DomEvent, TresCamera, TresEvent, TresInstance } from 'src/types'
+import type { DomEvent, TresCamera, TresEvent, TresInstance } from '../../types'
 import type { Intersection, Object3D, Object3DEventMap } from 'three'
 import type { ShallowRef } from 'vue'
 import type { TresContext } from '../useTresContextProvider'
diff --git a/src/composables/useTresEventManager/index.ts b/src/composables/useTresEventManager/index.ts
index a20f436..c84f2cf 100644
--- a/src/composables/useTresEventManager/index.ts
+++ b/src/composables/useTresEventManager/index.ts
@@ -1,4 +1,4 @@
-import type { EmitEventFn, EmitEventName, Intersection, TresEvent, TresInstance, TresObject } from 'src/types'
+import type { EmitEventFn, EmitEventName, Intersection, TresEvent, TresInstance, TresObject } from '../../types'
 import type { Object3D, Object3DEventMap, Scene } from 'three'
 import type { TresContext } from '../useTresContextProvider'
 import { shallowRef } from 'vue'
diff --git a/src/devtools/plugin.ts b/src/devtools/plugin.ts
index 8b4ab89..f8222b0 100644
--- a/src/devtools/plugin.ts
+++ b/src/devtools/plugin.ts
@@ -188,6 +188,7 @@ export function registerTresDevtools(app: DevtoolsApp, tres: TresContext) {
 
           if (instance.isScene) {
             payload.state.info = {
+              // @ts-expect-error FIXME
               objects: instance.children.length,
               memory: calculateMemoryUsage(instance),
               calls: tres.renderer.value.info.render.calls,
diff --git a/src/types/index.ts b/src/types/index.ts
index 40a3918..1bf951c 100644
--- a/src/types/index.ts
+++ b/src/types/index.ts
@@ -198,10 +198,10 @@ export type TresControl = THREE.EventDispatcher & { enabled: boolean }
 
 export type WithMathProps<P> = { [K in keyof P]: P[K] extends MathRepresentation | THREE.Euler ? MathType<P[K]> : P[K] }
 
-interface RaycastableRepresentation {
+export interface RaycastableRepresentation {
   raycast: (raycaster: THREE.Raycaster, intersects: THREE.Intersection[]) => void
 }
-type EventProps<P> = P extends RaycastableRepresentation ? Partial<EventHandlers> : unknown
+export type EventProps<P> = P extends RaycastableRepresentation ? Partial<EventHandlers> : unknown
 
 export interface VueProps {
   children?: VNode[]
@@ -217,8 +217,8 @@ export type ThreeElement<T extends ConstructorRepresentation> = Mutable<
   Overwrite<ElementProps<T>, Omit<InstanceProps<InstanceType<T>, T>, 'object'>>
 >
 
-type ThreeExports = typeof THREE
-type ThreeInstancesImpl = {
+export type ThreeExports = typeof THREE
+export type ThreeInstancesImpl = {
   [K in keyof ThreeExports as Uncapitalize<K>]: ThreeExports[K] extends ConstructorRepresentation
     ? ThreeElement<ThreeExports[K]>
     : never
@@ -228,16 +228,10 @@ export interface ThreeInstances extends ThreeInstancesImpl {
   primitive: Omit<ThreeElement<any>, 'args'> & { object: object }
 }
 
-type TresComponents = {
+export type TresComponents = {
   [K in keyof ThreeInstances as `Tres${Capitalize<string & K>}`]: DefineComponent<ThreeInstances[K]>
 }
 
 declare module 'vue' {
-  export interface GlobalComponents extends TresComponents { }
-}
-declare module '@vue/runtime-core' {
   interface GlobalComponents extends TresComponents { }
 }
-declare module '@vue/runtime-dom' {
-  interface GlobalComponents extends TresComponents {}
-}
diff --git a/src/utils/index.ts b/src/utils/index.ts
index 80704a8..6293bc7 100644
--- a/src/utils/index.ts
+++ b/src/utils/index.ts
@@ -1,5 +1,5 @@
-import type { nodeOps } from 'src/core/nodeOps'
-import type { AttachType, LocalState, TresInstance, TresObject, TresPrimitive } from 'src/types'
+import type { nodeOps } from '../core/nodeOps'
+import type { AttachType, LocalState, TresInstance, TresObject, TresPrimitive } from '../types'
 import type { Material, Mesh, Object3D, Texture } from 'three'
 import type { TresContext } from '../composables/useTresContextProvider'
 import { DoubleSide, MathUtils, MeshBasicMaterial, Scene, Vector3 } from 'three'
diff --git a/src/utils/is.ts b/src/utils/is.ts
index 4e7af96..9dd66f4 100644
--- a/src/utils/is.ts
+++ b/src/utils/is.ts
@@ -1,4 +1,4 @@
-import type { TresObject, TresPrimitive } from 'src/types'
+import type { TresObject, TresPrimitive } from '../types'
 import type { BufferGeometry, Camera, Fog, Light, Material, Object3D, Scene } from 'three'
 
 export function und(u: unknown) {
diff --git a/vite.config.ts b/vite.config.ts
index 7013397..e3255c8 100644
--- a/vite.config.ts
+++ b/vite.config.ts
@@ -31,7 +31,6 @@ export default defineConfig({
       },
     }),
     dts({
-      insertTypesEntry: true,
       rollupTypes: true,
     }),
     banner({

You can avoid breaking change this way.

userquin · 2024-12-22T13:12:51Z

Dont augment @vue/** module, augment vue instead (global components and directives iirc should go there):

fix(nuxt): only augment vue, not sub-packages nuxt/nuxt#28542 (comment)

fix: node16 types

2da056a

alvarosabu added the p4-important-bug Violate documented behavior or significantly improve performance (priority) label Dec 20, 2024

alvarosabu requested a review from userquin December 20, 2024 16:39

alvarosabu added 3 commits December 20, 2024 17:48

chore: pnpm override to typescript 5.7.2

6eb91a7

chore: get caret back to attw cli dep

3bb4aef

chore: update lock

4f199d0

alvarosabu mentioned this pull request Dec 20, 2024

fix: node16 types #885

Closed

alvarosabu self-assigned this Dec 20, 2024

userquin reviewed Dec 20, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

userquin reviewed Dec 20, 2024

View reviewed changes

renovate.json Outdated Show resolved Hide resolved

userquin and others added 2 commits December 21, 2024 10:09

chore: add link to node16 ts (#889)

6c45a1a

chore: use caret for typescript, remove ignore deps from renovate

d6b658f

ci: increase space size and node version for netlify build

126316f

ci: check types

b673728

alvarosabu requested a review from userquin December 22, 2024 09:49

userquin approved these changes Dec 22, 2024

View reviewed changes

alvarosabu marked this pull request as draft December 22, 2024 11:36

fix!: remove submodules exports

b848a32

BREAKING CHANGE: import submodules like `@Tresjs/core/components` will no longer be possible. Use `@Tresjs/core` instead

fix: export all types for TresComponents

a086ca1

alvarosabu changed the base branch from main to next December 22, 2024 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: node16 types #888

fix: node16 types #888

alvarosabu commented Dec 20, 2024 •

edited

Loading

netlify bot commented Dec 20, 2024 •

edited

Loading

pkg-pr-new bot commented Dec 20, 2024 •

edited

Loading

userquin commented Dec 20, 2024

userquin Dec 20, 2024

userquin Dec 20, 2024

brc-dd commented Dec 22, 2024 •

edited

Loading

alvarosabu commented Dec 22, 2024

brc-dd commented Dec 22, 2024 •

edited

Loading

alvarosabu commented Dec 22, 2024

brc-dd commented Dec 22, 2024

userquin left a comment

alvarosabu commented Dec 22, 2024

brc-dd commented Dec 22, 2024 •

edited

Loading

alvarosabu commented Dec 22, 2024

brc-dd commented Dec 22, 2024

alvarosabu commented Dec 22, 2024

userquin commented Dec 22, 2024

brc-dd commented Dec 22, 2024

brc-dd commented Dec 22, 2024 •

edited

Loading

alvarosabu commented Dec 22, 2024 •

edited

Loading

userquin commented Dec 22, 2024

userquin commented Dec 22, 2024

brc-dd commented Dec 22, 2024

alvarosabu commented Dec 22, 2024 •

edited

Loading

brc-dd commented Dec 22, 2024 •

edited

Loading

userquin commented Dec 22, 2024 •

edited

Loading

fix: node16 types #888

Are you sure you want to change the base?

fix: node16 types #888

Conversation

alvarosabu commented Dec 20, 2024 • edited Loading

netlify bot commented Dec 20, 2024 • edited Loading

✅ Deploy Preview for tresjs-docs ready!

pkg-pr-new bot commented Dec 20, 2024 • edited Loading

userquin commented Dec 20, 2024

userquin Dec 20, 2024

Choose a reason for hiding this comment

userquin Dec 20, 2024

Choose a reason for hiding this comment

brc-dd commented Dec 22, 2024 • edited Loading

alvarosabu commented Dec 22, 2024

brc-dd commented Dec 22, 2024 • edited Loading

alvarosabu commented Dec 22, 2024

brc-dd commented Dec 22, 2024

userquin left a comment

Choose a reason for hiding this comment

alvarosabu commented Dec 22, 2024

brc-dd commented Dec 22, 2024 • edited Loading

alvarosabu commented Dec 22, 2024

brc-dd commented Dec 22, 2024

alvarosabu commented Dec 22, 2024

userquin commented Dec 22, 2024

brc-dd commented Dec 22, 2024

brc-dd commented Dec 22, 2024 • edited Loading

alvarosabu commented Dec 22, 2024 • edited Loading

userquin commented Dec 22, 2024

userquin commented Dec 22, 2024

brc-dd commented Dec 22, 2024

alvarosabu commented Dec 22, 2024 • edited Loading

brc-dd commented Dec 22, 2024 • edited Loading

userquin commented Dec 22, 2024 • edited Loading

alvarosabu commented Dec 20, 2024 •

edited

Loading

netlify bot commented Dec 20, 2024 •

edited

Loading

pkg-pr-new bot commented Dec 20, 2024 •

edited

Loading

brc-dd commented Dec 22, 2024 •

edited

Loading

brc-dd commented Dec 22, 2024 •

edited

Loading

brc-dd commented Dec 22, 2024 •

edited

Loading

brc-dd commented Dec 22, 2024 •

edited

Loading

alvarosabu commented Dec 22, 2024 •

edited

Loading

alvarosabu commented Dec 22, 2024 •

edited

Loading

brc-dd commented Dec 22, 2024 •

edited

Loading

userquin commented Dec 22, 2024 •

edited

Loading