Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: replace all API "Response()" with new "APIResponse()" #517

Closed
TreyWW opened this issue Oct 19, 2024 · 3 comments · Fixed by #529
Closed

bug: replace all API "Response()" with new "APIResponse()" #517

TreyWW opened this issue Oct 19, 2024 · 3 comments · Fixed by #529

Comments

@TreyWW
Copy link
Owner

TreyWW commented Oct 19, 2024

What version of MyFinances are you currently using?

latest

What device type are you currently facing the issue on?

No response

Describe the bug

Replace all old public API responses from:

    return Response({"success": True, "invoice_id": invoice.id}, status=status.HTTP_201_CREATED)

new:

APIResponse(True, {"invoice_id": invoice.id})
@guninwasan
Copy link
Contributor

Hey @TreyWW, can I work on this issue?

@TreyWW
Copy link
Owner Author

TreyWW commented Nov 9, 2024

Hey @guninwasan of course, let me know if you need anything clarifying

@guninwasan
Copy link
Contributor

hey @TreyWW, can you take a look at this PR? Let me know if I need to make any changes to it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants