Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #517
This PR focuses on standardizing the response format by replacing
Response
withAPIResponse
. This change ensures consistency in how API responses are structured and handled.Key changes include:
Response
withAPIResponse
indef _wrapped_view
to handle authentication and permission errors consistently (backend/core/api/public/decorators.py
).delete_invoice_endpoint
to useAPIResponse
for handling invoice deletion outcomes (backend/core/api/public/endpoints/Invoices/delete.py
).download
to useAPIResponse
for handling PDF generation errors (backend/core/api/public/endpoints/Invoices/download_pdf.py
).edit_invoice_endpoint
to useAPIResponse
for handling invoice editing outcomes (backend/core/api/public/endpoints/Invoices/edit.py
).get_invoices_endpoint
to useAPIResponse
for handling invoice retrieval results (backend/core/api/public/endpoints/Invoices/get.py
).client_delete_endpoint
to useAPIResponse
for handling client deletion outcomes (backend/core/api/public/endpoints/clients/delete.py
).system_health_endpoint
to useAPIResponse
for handling system health check results (backend/core/api/public/endpoints/system_health.py
).webhook_task_queue_handler_view_endpoint
to useAPIResponse
for handling webhook task outcomes (backend/core/api/public/endpoints/webhooks/webhook_task_queue_handler.py
).Checklist
djLint-er on any new code
(checks
will
fail without)
changes
What type of PR is this?
Added/updated tests?
Related PRs, Issues etc