Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - Issue 304. #478

Merged
merged 9 commits into from
Sep 18, 2024
Merged

FIX - Issue 304. #478

merged 9 commits into from
Sep 18, 2024

Conversation

pvvramakrishnarao234
Copy link
Contributor

@pvvramakrishnarao234 pvvramakrishnarao234 commented Sep 13, 2024

Description

Added a condition at /invoices/single so that last two invoices have a dropup and not go behind the parent container.

Checklist

  • [Yes] Ran the Black Formatter and
    djLint-er on any new code
    (checks will fail without)
  • [Not needed] Made any changes or additions to the documentation where required
  • [No] Changes generate no new warnings/errors
  • [No] New and existing unit tests pass locally with my
    changes

What type of PR is this?

  • 🐛 Bug Fix
  • ♻️ Code Refactor

Added/updated tests?

  • 🙅 no, because they aren't needed

Related PRs, Issues etc

@TreyWW
Copy link
Owner

TreyWW commented Sep 14, 2024

Awaiting filter removal from template

@pvvramakrishnarao234
Copy link
Contributor Author

removed filters

@pvvramakrishnarao234
Copy link
Contributor Author

Removed migration file

@TreyWW
Copy link
Owner

TreyWW commented Sep 18, 2024

Apologies for the delay. If possible today I will try the changes locally make sure it works as expected on a few devices, and hopefully get this merged!

Thanks for your patience, I appreciate the contribution

@pvvramakrishnarao234
Copy link
Contributor Author

ok, got it

@TreyWW
Copy link
Owner

TreyWW commented Sep 18, 2024

Yep seems to work well on mobile and desktop. Thanks for your first contribution @pvvramakrishnarao234, much appreciated! Let me know on discord if there's anything further you'd like to work on, there's a few interesting ideas i'll be implementing in the next few weeks so it's a good time to spot in :)

@TreyWW TreyWW merged commit 2491059 into TreyWW:main Sep 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Invoices->Actions menu is under other template
2 participants