Use .at() for indexing instead of C style array indices #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This throws an exception on out of bounds array accesses rather than a segfault |
added 2 commits
March 31, 2023 18:49
jlbabilino
reviewed
Mar 31, 2023
src/main/include/Constants.hpp
Outdated
| constexpr int kRedBlueSwitchPort = 10; | ||
|
|
||
| /// LED strip | ||
| constexpr int kLEDStripLength = 22; | ||
| constexpr int kAltLEDStripLength = 18; | ||
| constexpr int kLEDBuffLength = kLEDStripLength * 4 + kAltLEDStripLength; | ||
| constexpr bool kStripDirections[] = {false, true, true, | ||
| true}; // false means up, true means down | ||
| const std::vector<bool> kStripDirections = { |
There was a problem hiding this comment.
This may violate this issue: #56
jlbabilino
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.