Skip to content

Conversation

fkuo
Copy link

@fkuo fkuo commented Jan 29, 2014

No description provided.

@davepacheco
Copy link
Contributor

Thanks for doing this! Can you add some tests, an example, and update README.md? My main question is what the expected behavior is when you start an operation on a barrier that's aborted? The example would help clarify that.

Also, is "drain" the right event for conveying the error?

CC'ing @jclulow, since he's interested in this.

@jclulow
Copy link
Contributor

jclulow commented Feb 4, 2014

If there's a different event for conveying errors, e.g. "error", then it would be good to ensure that "drain" does not ever fire in the error case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants