Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/leo3friedman/login page #58

Merged
merged 5 commits into from
May 28, 2024
Merged

Conversation

leo3friedman
Copy link
Contributor

Tracking Info

Resolves #55

Changes

Added styling for login page

Changed validation to return False on validation fail rather than error

Testing

Manual testing

Confirmation of Change

image

@leo3friedman leo3friedman requested a review from Miyuki-L as a code owner May 16, 2024 03:05
@Miyuki-L Miyuki-L requested a review from sidhantrohatgi May 21, 2024 22:43
Copy link
Member

@sidhantrohatgi sidhantrohatgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@leo3friedman leo3friedman merged commit 9b07edf into main May 28, 2024
2 checks passed
@leo3friedman leo3friedman deleted the feature/leo3friedman/login-page branch May 28, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login Page
3 participants