Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created testimony backend routes and validator #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SaazM
Copy link

@SaazM SaazM commented Jan 23, 2025

resolves #25

Created a new Testimony document. Each document requires the following fields:

  • body - String
  • image (string, url to image. we will add image uploading functionality later)
  • source (string, name and occupation of person who gave the quote)

All fields validated for create request and update request

Get-all Request:
Screenshot 2025-01-22 at 5 26 53 PM

Create Request:
Screenshot 2025-01-22 at 5 27 17 PM

Update Request (body updated from "boy" to "body") :
Screenshot 2025-01-22 at 5 27 55 PM

Delete Request:
Screenshot 2025-01-22 at 5 28 07 PM

Get-all Request after deleting:
Screenshot 2025-01-22 at 5 34 18 PM

@SaazM SaazM requested a review from mraysu as a code owner January 23, 2025 01:35
@SaazM SaazM requested review from kevindo0720 and kilehsu January 23, 2025 01:36
@mraysu mraysu removed the request for review from kevindo0720 January 23, 2025 21:39
@mraysu
Copy link
Collaborator

mraysu commented Jan 23, 2025

Looks great! Everything works well and your code is organized. Would you mind changing all instances of "testimony" to "quote" to reflect the github issue #25 specifications? It's nitpicky but I would prefer to standardize it now to reduce readability issues in the future.

@mraysu mraysu requested review from yyunshanli and removed request for kilehsu January 23, 2025 21:48
Copy link
Contributor

@yyunshanli yyunshanli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested and everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Testimony Backend Route
3 participants