Karenyan/mailing list backend route #33
Open
+105
−333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #10
Changes
I created the mongoose schema for a subscription and I implemented the POST, GET, and DELETE routes for the subscriptions.
Testing
I tested on valid names + emails to check that they could be added and deleted properly. I also check that invalid subscriptions could not be added or deleted (valid names + invalid emails, invalid names + valid emails). I'm not sure if when an invalid email is deleted what error it should throw, so right now it is set at 200.
Confirmation of Change
PUT valid name & email
PUT invalid name & valid email
PUT valid name & invalid email
DELETE Valid name & email
DELETE valid name & invalid email
GET All
