Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign-in Page Frontend #12

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Sign-in Page Frontend #12

wants to merge 7 commits into from

Conversation

aaronchan32
Copy link
Member

Tracking Info

Resolves #4

Changes

  • Created /signin route that renders Sign-in component
  • Increased input fields to a max-width of 320px
  • Added password visibility toggle to the TextBox component
  • Merged with create-account branch
  • Created /signup route for Create Account component (now renamed to SignUp)

Testing

Confirmation of Change

image

Additional Notes

  • The password input field placeholder and masked text is an asterisk (*) on the Figma design, but the most convenient implementation has limited symbols so we are using default dots (●). Allison has confirmed that this is okay.
  • I added a subtle background-color transition to the Sign in button on hover. We should confirm with designers if this is okay and standardize it across all selectable inputs
  • We still need to add logic to retrieve form data. This can a separate issue and we can consider using React Hook Form to handle multiple input fields and Zod for input validation.

Copy link
Collaborator

@eshaan-s18 eshaan-s18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job everyone who worked on this PR! It looks awesome! Some small bugs that I noticed were:

  1. The password visibility toggle button overlaps the input field when the there is a long password for both pages (create an account and sign-in). Screenshots:
Screenshot 2025-01-25 at 10 01 07 AM Screenshot 2025-01-25 at 10 01 14 AM
  1. The second thing I noticed is that on the sign-in page the forgot password button's width is not wrapped around the hyperlink. In my screenshot I made the background red just to show what I mean. If you could fix it to wrap around the text like the "Sign-up" hyperlink that would be awesome. Screenshot:
Screenshot 2025-01-25 at 10 07 38 AM

LMK when you fix these small issues and I'll approve the PR! It looks fantastic other than that and the routing links work great!! Thanks so much both teams for all your hard work!

@aaronchan32
Copy link
Member Author

Thanks for catching these bugs! They should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign-In Page (Frontend Only)
3 participants