-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign-in Page Frontend #12
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job everyone who worked on this PR! It looks awesome! Some small bugs that I noticed were:
- The password visibility toggle button overlaps the input field when the there is a long password for both pages (create an account and sign-in). Screenshots:
- The second thing I noticed is that on the sign-in page the forgot password button's width is not wrapped around the hyperlink. In my screenshot I made the background red just to show what I mean. If you could fix it to wrap around the text like the "Sign-up" hyperlink that would be awesome. Screenshot:
LMK when you fix these small issues and I'll approve the PR! It looks fantastic other than that and the routing links work great!! Thanks so much both teams for all your hard work!
Thanks for catching these bugs! They should be fixed now. |
Tracking Info
Resolves #4
Changes
/signin
route that renders Sign-in componentTextBox
componentcreate-account
branch/signup
route for Create Account component (now renamed to SignUp)Testing
Confirmation of Change
Additional Notes