make Op Stack Table variable length #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only update the running product when the op stack's size changes.
The Op Stack Table now has a padding indicator. It does not generate spurious clock jump difference lookup any longer. Hence, the Processor Table does not need to take them into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes internal behavior (“only”). It prepares Triton VM to handle instructions that change the op stack's length by more than one between two consecutive execution cycles. While the constraints for any thusly altered instructions will have to be adopted for the instruction's new behavior, the op stack's constraints will remain stable1.
Footnotes
excepting as-of-yet undiscovered bugs ↩