Skip to content

fix: resolve NameError in settings Appearance tab by defining select_widget #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkshajSinghal merged 6 commits into from
Jun 10, 2026
Merged

fix: resolve NameError in settings Appearance tab by defining select_widget #51

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ef2cc9d
fix: resolve NameError in settings Appearance tab by defining select_…
Jun 8, 2026
3d21a29
test: fix help docs test by adding _import_module to fake kernel
Jun 8, 2026
0d45b9e
fix: resolve NameError crash at startup by defining argv before use
Jun 8, 2026
9d2eefb
merge: resolve cli.py conflict with upstream/main
Jun 9, 2026
5e0c4ca
fix: remove dead _fake_import_module from test
Jun 9, 2026
5ffd623
Merge branch 'main' into fix/settings-select-widget-nameerror
AkshajSinghal Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/test_help_docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,24 @@
from __future__ import annotations

import importlib
from types import SimpleNamespace

from trushell.commands.core import run_help


def test_run_help_prints_docstring_for_known_command(monkeypatch, capsys):
def _fake_import_module(path: str):
module = importlib.import_module(path.replace("/", ".").removesuffix(".py"))
return module
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

fake_kernel = SimpleNamespace(
registry={
"settings": {
"path": "trushell/commands/settings.py",
"function": "run_settings",
}
}
},
_import_module=_fake_import_module,
)

# Provide a minimal module object with the expected function and
Expand Down
3 changes: 0 additions & 3 deletions trushell/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ def app_with_lower() -> None:
if len(sys.argv) > 1:
argv_copy = sys.argv.copy()
if argv_copy[1].lower() not in {"--help", "-h", "version"}:
# Normalize the command name to lowercase for case-insensitive
# invocation, but preserve the case of subsequent arguments
# (e.g., filenames) which may be case-sensitive.
first = argv_copy[1].lower()
rest = argv_copy[2:]
raw = " ".join([first] + rest)
Expand Down
12 changes: 4 additions & 8 deletions trushell/commands/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,15 +167,11 @@ def add_field(label_text: str, widget: Static | Input | Select | Switch) -> None
Input(value=str(self.dirty_settings.get("prompt_symbol", self.settings.get("prompt_symbol", "➜"))), id="prompt_symbol"),
)
elif current_cat == "Appearance":
add_field(
"Theme:",
Select(
options=self.THEME_OPTIONS,
value=str(self.dirty_settings.get("theme", self.settings.get("theme", "dark"))),
id="theme_selector",
),
select_widget = Select(
options=self.THEME_OPTIONS,
value=str(self.dirty_settings.get("theme", self.settings.get("theme", "dark"))),
id="theme_selector",
)
select_widget.watch_value(lambda value: self._track_change("theme", value))
add_field("Theme:", select_widget)
elif current_cat == "Navigation":
add_field(
Expand Down
Loading