Skip to content

Conversation

mike182uk
Copy link
Member

ref https://linear.app/ghost/issue/PROD-2455
ref TryGhost/Ghost#24985

The admin-x-activitypub script has been renamed to just activitypub so the client config endpoint should be updated to reflect this change

Copy link

coderabbitai bot commented Sep 25, 2025

Walkthrough

The backend-driven frontend client identifier was renamed from "admin-x-activitypub" to "activitypub". The change updates emitted JSON client fields and the constructed CDN URL to reference the "activitypub" bundle. No control flow, version derivation, or error handling logic was modified. An ADR document was updated to reflect the same renaming.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the primary change by stating that the client config controller has been updated to reference the renamed script, which aligns directly with the changes made in this pull request.
Description Check ✅ Passed The description directly explains that the admin-x-activitypub script was renamed to activitypub and that the client config endpoint has been updated accordingly, referencing relevant issue links to provide context for the change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mike-prod-2455-rename-admin-x-activitypub-to-activitypub-in-ghost

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e37743 and 09f052a.

📒 Files selected for processing (2)
  • adr/0002-frontend-backend-versioning.md (1 hunks)
  • src/http/api/client-config.controller.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • adr/0002-frontend-backend-versioning.md
🧰 Additional context used
📓 Path-based instructions (1)
src/**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.ts: Never use direct string comparisons for ActivityPub IDs; use SHA256 hash-based lookups instead
Use Result helper functions (isError, getError, getValue) and avoid destructuring Result values directly
Awilix uses CLASSIC injection: constructor parameter names must match their registration names
Define routes using decorators rather than direct registration
Prefer immutable entities that emit domain events over mutable entities with dirty flags
Use structured error objects with context in Result types instead of string literals
Prefer class-based handlers with dependency injection over function factories

Files:

  • src/http/api/client-config.controller.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build / Build Docker Images (linux/amd64, amd64)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ref https://linear.app/ghost/issue/PROD-2455
ref TryGhost/Ghost#24985

The `admin-x-activitypub` script has been renamed to just `activitypub` so the
client config endpoint should be updated to reflect this change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants