Prototype threaded comments rendering#27601
Draft
jonatansberg wants to merge 1 commit intomainfrom
Draft
Conversation
Prototype-first comments rendering needs to preserve conversation flow without backend API changes. This adds reply graph hydration, primary branch rendering, compact branch toggles, and adjusted connector rails for the exploratory UI.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 25046947807 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
jonatansberg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a proof-of-concept for conversation-preserving rendering in
comments-ui.Notes
This intentionally avoids backend/API changes. Network efficiency and production-grade ranking can be revisited after the UI direction is evaluated.
Test file changes from the prototype iteration were left out of this commit because this pass is focused on the proof of concept UI behavior.
Validation
pnpm --filter @tryghost/comments-ui buildhttp://localhost:2368/tangle-comments/http://localhost:2368/nested-comments/Unit/e2e suites were not run for this prototype pass.