Added formatResponse option to the ghost content API #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextwebb
changed the title
|
@nextwebb it seems that your PR contains a lot of file permission changes and also needs conflicts resolving. Could you look at both of those issues please? |
phawazzzy
suggested changes
Apr 22, 2020
|
|
||
| } | ||
| if(formatResponse === true ){ | ||
| return Object.assign(res.dat, {meta: res.data.meta}); |
There was a problem hiding this comment.
this should be return Object.assign(res.data, {meta: res.data.meta}); and not return Object.assign(res.dat, {meta: res.data.meta});
| return GhostContentAPI({url, version, key, formatResponse}); | ||
| } | ||
|
|
||
| if (!formatResponse) { |
There was a problem hiding this comment.
I feel the formatResponse option should not throw an error if it isnt declared or assigned a value...
It should default to true just as mentioned here by the first person who commented on the issue here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added formatResponse option to the ghost content API,
A fix for "Add an option to skip response formatting in Content/Admin API SDKs #73"
#73
The contentAPI will now have the "format response" boolean property, as an option
like this:
const api = new GhostContentAPI({
url: 'YOUR URL',
key: 'YOUR KEY',
version: "VERSION",
formatResponse: true/false
})