-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emnapi WebAssembly build #1674
Open
toyobayashi
wants to merge
9
commits into
TryGhost:master
Choose a base branch
from
toyobayashi:node-wasm-emnapi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
emnapi WebAssembly build #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toyobayashi
force-pushed
the
node-wasm-emnapi
branch
from
February 4, 2023 17:02
5bc89b6
to
a4a27ca
Compare
Could you please enable CI for me? |
node-sqlite3/lib/sqlite3-binding.js Lines 3 to 6 in 88fd747
not sure why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created emnapi for porting Node.js addons written in Node-API to Emscripten WebAssembly. I successfully built this project to wasm, all test cases passed
except the one related to.async_hooks
, which is not supported by emnapiyarn node-pre-gyp configure --nodedir=./wasm --target_arch=wasm32 emmake yarn node-pre-gyp build --nodedir=./wasm --target_arch=wasm32 npx --arch=wasm32 yarn test
Update:
emnapi 0.28.1 has added the
async_hooks
support on Node.js. All test passed on my local machine.