Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that no index out of bounds read can happen when populating node modules #290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

makepanic
Copy link
Contributor

fixes #289

@makepanic
Copy link
Contributor Author

@viktoria-shirunova can you check if this fixes your issue? I couldn't reproduce it locally but from the stacktrace it seems like the issue was the access to index 0 when its size was 0.
We're now trying to be more graceful. I'm not sure if a selection model of null works though.

@viktoria-shirunova
Copy link

@makepanic I'm sorry, but still the version 2019.3.1-0 is published where the exception is reproduced and, unfortunately, I don't know how where from to take the plugin other way. For reproducing - you need to be sure that no node.js is installed on your computer. If any node.js is installed - no exception then.

@makepanic
Copy link
Contributor Author

I've tried to uninstall node.

The intellij node picker widget has a graceful fallback for me:
20191210-201202

The stacktrace pointed to an issue where the module picker had no modules to pick from.
We removed the nullpointer exception but I can't get this to happen locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants