Skip to content

Commit

Permalink
Move to Accessors.jl from Setfield.jl (#91)
Browse files Browse the repository at this point in the history 
* move to Accessors

* fix tests

* fix test error

* add compat

* version bump

* Update src/varname.jl

Co-authored-by: Tor Erlend Fjelde <[email protected]>

* Update src/varname.jl

* remove type piracy in  `show` function

* fix print behavior

* removed composition of a varname to a lens

* update doc

* remove `Setfield`

* add some type stability tests and additional doctests

* fix test error

* Update src/varname.jl

Co-authored-by: Tor Erlend Fjelde <[email protected]>

* copy functions from Setfield and recover the interpolation abilities

* fix some comments

---------

Co-authored-by: Tor Erlend Fjelde <[email protected]>
  • Loading branch information
@sunxd3 @torfjelde
sunxd3 and torfjelde authored Mar 28, 2024
1 parent 1fd87cf commit f3fbce0
Show file tree
Hide file tree
Showing 5 changed files with 262 additions and 168 deletions.
7 changes: 4 additions & 3 deletions Project.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,18 @@ uuid = "7a57a42e-76ec-4ea3-a279-07e840d6d9cf"
keywords = ["probablistic programming"]
license = "MIT"
desc = "Common interfaces for probabilistic programming"
version = "0.7.1"
version = "0.8.0"

[deps]
AbstractMCMC = "80f14c24-f653-4e6a-9b94-39d6b0f70001"
Accessors = "7d9f7c33-5ae7-4f3b-8dc6-eff91059b697"
DensityInterface = "b429d917-457f-4dbc-8f4c-0cc954292b1d"
MacroTools = "1914dd2f-81c6-5fcd-8719-6d5c9610ff09"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Setfield = "efcf1570-3423-57d1-acb7-fd33fddbac46"

[compat]
AbstractMCMC = "2, 3, 4, 5"
Accessors = "0.1"
DensityInterface = "0.4"
Random = "1.6"
Setfield = "0.8.2, 1"
julia = "~1.6.6, 1.7.3"
2 changes: 1 addition & 1 deletion src/AbstractPPL.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module AbstractPPL
# VarName
export VarName,
getsym,
getlens,
getoptic,
inspace,
subsumes,
subsumedby,
Expand Down
Loading

2 comments on commit f3fbce0

@yebai
Copy link
Member

@yebai yebai commented on f3fbce0 Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/103811

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.8.0 -m "<description of version>" f3fbce0932030372d0a7bca1325f78792583395d
git push origin v0.8.0

Please sign in to comment.