-
Notifications
You must be signed in to change notification settings - Fork 8
Backport 3-arg rand
to AbstractPPL 0.5.x
#80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, @sunxd3 -- it looks good; feel free to merge once CI passes. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## releases-0.5.x #80 +/- ##
=================================================
Coverage ? 81.02%
=================================================
Files ? 3
Lines ? 274
Branches ? 0
=================================================
Hits ? 222
Misses ? 52
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
For future backports, a common approach (that we use e.g. also in SpecialFunctions) is to cherry-pick the relevant commit. See e.g. https://github.com/JuliaLang/julia/blob/a77ba79855f400420ccaa09c153ecec2784e386e/doc/src/devdocs/build/distributing.md#cherry-picking-commits for an explanation. The advantage is that one can then resolve conflicts similar to merges and git copies information such as the original commit message and contributors. |
The changes were done by local |
rand
defaults have been added since AbstractPPL v0.6.2 (#79), backporting to v0.5 for compatibility.