Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AbstractMCMCv5.0 to Project.toml #88

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Add AbstractMCMCv5.0 to Project.toml #88

merged 2 commits into from
Nov 8, 2023

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Nov 8, 2023

@sunxd3
Copy link
Member Author

sunxd3 commented Nov 8, 2023

@yebai @devmotion I am not sure how to handle versioning and backporting here, shed some light?

@devmotion
Copy link
Member

Backporting?

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b342b3d) 84.82% compared to head (12bf97f) 84.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files           3        3           
  Lines         145      145           
=======================================
  Hits          123      123           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devmotion
Copy link
Member

It seems AbstractPPL is not affected by the breaking changes in AbstractMCMC and does not export any of its functionality. So it should be fine to tag a non-breaking release IMO.

@sunxd3 sunxd3 marked this pull request as ready for review November 8, 2023 14:18
@yebai yebai merged commit 4960d49 into main Nov 8, 2023
12 checks passed
@yebai yebai deleted the sunxd3-patch-1 branch November 8, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants