Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
TuringLang · Sep 6, 2023 · 34e422a · 34e422a
1 parent a18b435
commit 34e422a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/ext/DynamicPPLMCMCChainsExt.jl b/ext/DynamicPPLMCMCChainsExt.jl
@@ -10,7 +10,8 @@ end
 
 # TODO: Add proper overload of `Base.getindex` to Turing.jl?
 function _getindex(c::MCMCChains.Chains, sample_idx, vn::DynamicPPL.VarName, chain_idx)
-    DynamicPPL.supports_varname_indexing(c) || error("Chains do not support indexing using $vn.")
+    DynamicPPL.supports_varname_indexing(c) ||
+        error("Chains do not support indexing using $vn.")
     return c[sample_idx, c.info.varname_to_symbol[vn], chain_idx]
 end
 
@@ -23,7 +24,9 @@ function DynamicPPL.generated_quantities(model::DynamicPPL.Model, chain::MCMCCha
             for vn in keys(chain.info.varname_to_symbol)
                 # FIXME: Make it so we can support `chain[sample_idx, vn, chain_idx]`
                 # indexing instead of the `chain[vn][sample_idx, chain_idx]` below.
-                DynamicPPL.nested_setindex!(varinfo, _getindex(chain, sample_idx, vn, chain_idx), vn)
+                DynamicPPL.nested_setindex!(
+                    varinfo, _getindex(chain, sample_idx, vn, chain_idx), vn
+                )
             end
         else
             # NOTE: This can be quite unreliable (but will warn the uesr in that case).

diff --git a/src/utils.jl b/src/utils.jl
@@ -1061,8 +1061,7 @@ end
 
 # HACK: This should not be here.
 @generated function ConstructionBase.setproperties(
-    C::LinearAlgebra.Cholesky,
-    patch::NamedTuple{names}
+    C::LinearAlgebra.Cholesky, patch::NamedTuple{names}
 ) where {names}
     # Return early if we need be.
     (:L in names && :U in names) && return :(error("Cannot set both L and U"))

diff --git a/src/varinfo.jl b/src/varinfo.jl
@@ -1090,7 +1090,9 @@ function _nested_getindex(varinfo::VarInfo, md::Metadata, vn::VarName)
     return get(val, lens)
 end
 
-nested_setindex!(vi::VarInfo, val, vn::VarName) = _nested_setindex!(vi, getmetadata(vi, vn), val, vn)
+function nested_setindex!(vi::VarInfo, val, vn::VarName)
+    return _nested_setindex!(vi, getmetadata(vi, vn), val, vn)
+end
 function _nested_setindex!(vi::VarInfo, md::Metadata, val, vn::VarName)
     # If `vn` is in `vns`, then we can just use the standard `setindex!`.
     vns = md.vns

diff --git a/test/model.jl b/test/model.jl
@@ -299,9 +299,7 @@ end
         vns_to_syms = OrderedDict(zip(vns, syms))
 
         chain = MCMCChains.Chains(
-            permutedims(stack(vals)),
-            syms;
-            info = (varname_to_symbol = vns_to_syms,)
+            permutedims(stack(vals)), syms; info=(varname_to_symbol=vns_to_syms,)
         )
         display(chain)