Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the regular PR for accumulating breaking changes, to be released in the next minor version of DynamicPPL.
Potential 0.39 changes
Largely speaking I (Penny) am fairly happy with the general state of DPPL now. By far the biggest pain point for me, and the only thing I feel like I really want to change in the short term, is ThreadSafeVarInfo. Apart from that, in my opinion, it's now a good time to spend more resources on Turing, samplers, and optimisation.
Removal of parent contexts
PrefixContextwithmodel.prefix#1011NodeTrait#1052Unification of FixedContext and ConditionContext
Even if the contexts themselves don't get removed, I think it definitely makes sense to coalesce these two into a single thing to avoid weird behaviour.
A temporary solution to ThreadSafeVarInfo
See #1023 for the general motivation behind this (although that PR is probably not the right appraoch; it's too difficult to make it fully work correctly).
ThreadSafeVarInfoandthreadid#924