Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - CompatHelper: bump compat for AbstractPPL to 0.4, (keep existing compat) #349

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the AbstractPPL package from 0.3 to 0.3, 0.4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2021-12-12-00-05-47-105-04156430605 branch from 622ca79 to 16045ff Compare December 12, 2021 00:05
@yebai
Copy link
Member

yebai commented Feb 3, 2022

@phipsgabler Anything breaking in AbstractPPL v0.4?

@phipsgabler
Copy link
Member

Nothing that's not downwards compatible -- the breaking change was to specify that DensityInterface is required for the AbstractPPL interface. We don't have that yet (#340), but it won't result in any conflicts.

@yebai
Copy link
Member

yebai commented Feb 5, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 5, 2022

👎 Rejected by too few approved reviews

@yebai
Copy link
Member

yebai commented Feb 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 5, 2022
…at) (#349)

This pull request changes the compat entry for the `AbstractPPL` package from `0.3` to `0.3, 0.4`.
This keeps the compat entries for earlier versions.



Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Co-authored-by: Hong Ge <[email protected]>
@bors bors bot changed the title CompatHelper: bump compat for AbstractPPL to 0.4, (keep existing compat) [Merged by Bors] - CompatHelper: bump compat for AbstractPPL to 0.4, (keep existing compat) Feb 5, 2022
@bors bors bot closed this Feb 5, 2022
@bors bors bot deleted the compathelper/new_version/2021-12-12-00-05-47-105-04156430605 branch February 5, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants