Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Turing to 0.22 for package turing, (keep existing compat) #436

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Turing package from 0.21 to 0.21, 0.22 for package turing.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2022-11-15-00-10-53-509-02667259388 branch from 5bb7dab to 2205253 Compare November 15, 2022 00:11
@yebai
Copy link
Member

yebai commented Nov 22, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 22, 2022

👎 Rejected by too few approved reviews

@yebai
Copy link
Member

yebai commented Nov 22, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 22, 2022
…p existing compat) (#436)

This pull request changes the compat entry for the `Turing` package from `0.21` to `0.21, 0.22` for package turing.
This keeps the compat entries for earlier versions.



Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
@bors
Copy link
Contributor

bors bot commented Nov 22, 2022

Build failed:

@yebai
Copy link
Member

yebai commented Nov 22, 2022

It seems we still have some rough edges from #417

Test Summary:     | Pass  Error  Broken  Total
DynamicPPL.jl     | 3105      1       7   3113
  interface       | 2171              7   2178
  compat          |   16      1             17
    ad.jl         |   16      1             17
      logp        |   11      1             12
      dot_observe |    5                     5
  doctests        |    1                     1
  turing          |  917                   917
ERROR: LoadError: Some tests did not pass: 3105 passed, 0 failed, 1 errored, 7 broken.

@yebai
Copy link
Member

yebai commented Dec 19, 2022

@torfjelde can you take a look at the above failing CI test? It seems minor so would be good to fix it and merge this PR.

@yebai
Copy link
Member

yebai commented Dec 19, 2022

Closed in favour of #439

@yebai yebai closed this Dec 19, 2022
@yebai yebai deleted the compathelper/new_version/2022-11-15-00-10-53-509-02667259388 branch December 19, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant