Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immutable versions of
link
andinvlink
#525Immutable versions of
link
andinvlink
#525Changes from 7 commits
7d4bcd9
050e099
3a77e03
51013fb
0411c12
7f633a8
5d94640
d37527a
3f7f4b1
50b4332
19c0dce
98fb4ba
4000c12
2e7b71a
c822ea4
afc5a26
6465fa9
4cc0a45
d281487
6f55139
64ed2dd
d310fa8
6a21ee2
32b77ac
4810374
eca5189
e05bb09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 399 in src/abstract_varinfo.jl
Codecov / codecov/patch
src/abstract_varinfo.jl#L397-L399
Check warning on line 401 in src/abstract_varinfo.jl
Codecov / codecov/patch
src/abstract_varinfo.jl#L401
Check warning on line 403 in src/abstract_varinfo.jl
Codecov / codecov/patch
src/abstract_varinfo.jl#L403
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SampleFromPrior
was introduced before we had the mechanism for passing thet::Transformation
. It is now no longer necessary. In the longer run, we can consider replacingSampleFromPrior
with a suitablecontext
for clarity and consistency.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! This has always been the idea:) But for now, we're not quite read to do that.
Check warning on line 470 in src/abstract_varinfo.jl
Codecov / codecov/patch
src/abstract_varinfo.jl#L468-L470
Check warning on line 473 in src/abstract_varinfo.jl
Codecov / codecov/patch
src/abstract_varinfo.jl#L472-L473
Check warning on line 901 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L901
Check warning on line 904 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L904
Check warning on line 909 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L907-L909
Check warning on line 913 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L913
Check warning on line 918 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L916-L918
Check warning on line 920 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L920
Check warning on line 924 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L923-L924
Check warning on line 927 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L927
Check warning on line 930 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L929-L930
Check warning on line 937 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L934-L937
Check warning on line 939 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L939
Check warning on line 941 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L941
Check warning on line 943 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L943
Check warning on line 945 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L945
Check warning on line 955 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L949-L955
Check warning on line 958 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L958
Check warning on line 970 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L970
Check warning on line 973 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L973
Check warning on line 978 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L976-L978
Check warning on line 987 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L985-L987
Check warning on line 989 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L989
Check warning on line 993 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L992-L993
Check warning on line 996 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L996
Check warning on line 999 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L998-L999
Check warning on line 1006 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L1003-L1006
Check warning on line 1008 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L1008
Check warning on line 1010 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L1010
Check warning on line 1012 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L1012
Check warning on line 1014 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L1014
Check warning on line 1024 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L1018-L1024
Check warning on line 1027 in src/varinfo.jl
Codecov / codecov/patch
src/varinfo.jl#L1027