Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved varname_and_value_leaves for Cholesky #531

Merged
merged 3 commits into from
Sep 2, 2023

Conversation

torfjelde
Copy link
Member

@torfjelde torfjelde commented Sep 2, 2023

You can see the difference in the docstring I've edited.

This was suggested by @sethaxen as an alternative, which I quite like:)

The alternative is to flatten the PDMat instead, i.e. we return the covariance / correlation matrix represented by the cholesky instead of the cholesky factor itself.

Related discussion: TuringLang/Turing.jl#2071

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

Pull Request Test Coverage Report for Build 6057570891

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 81.207%

Totals Coverage Status
Change from base Build 6051965260: 0.01%
Covered Lines: 2381
Relevant Lines: 2932

💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (ba16e3b) 81.19% compared to head (99ea62c) 81.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   81.19%   81.20%   +0.01%     
==========================================
  Files          24       24              
  Lines        2930     2932       +2     
==========================================
+ Hits         2379     2381       +2     
  Misses        551      551              
Files Changed Coverage Δ
src/utils.jl 81.04% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements.

@torfjelde torfjelde enabled auto-merge September 2, 2023 13:03
@torfjelde torfjelde added this pull request to the merge queue Sep 2, 2023
Merged via the queue into master with commit 1824fad Sep 2, 2023
@torfjelde torfjelde deleted the torfjelde/better-varname-and-value-for-chol branch September 2, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants