Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name collision #539

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fix name collision #539

merged 3 commits into from
Sep 20, 2023

Conversation

torfjelde
Copy link
Member

@torfjelde torfjelde commented Sep 20, 2023

We're currently defining our own link and invlink even though these exist in Bijectors.jl, hence causing a lot of warning messages downstream.

As a hotfix, let's just overload the link and invlink from Bijectors.jl.

Long term we should probably either rename one of these, drop the ones from Bijectors.jl, or stop exporting one or both of them.

@torfjelde torfjelde requested a review from yebai September 20, 2023 12:52
@yebai yebai enabled auto-merge September 20, 2023 13:20
Project.toml Outdated Show resolved Hide resolved
@yebai yebai disabled auto-merge September 20, 2023 13:21
@yebai yebai enabled auto-merge September 20, 2023 13:21
@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 6249205203

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.395%

Totals Coverage Status
Change from base Build 6239353321: 0.0%
Covered Lines: 2428
Relevant Lines: 2983

💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4788480) 81.39% compared to head (02e82ff) 81.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #539   +/-   ##
=======================================
  Coverage   81.39%   81.39%           
=======================================
  Files          25       25           
  Lines        2983     2983           
=======================================
  Hits         2428     2428           
  Misses        555      555           
Files Changed Coverage Δ
src/DynamicPPL.jl 33.33% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yebai yebai added this pull request to the merge queue Sep 20, 2023
Merged via the queue into master with commit d204fcb Sep 20, 2023
12 of 13 checks passed
@yebai yebai deleted the torfjelde/fix-for-name-collision branch September 20, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants