-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove BangBang.possible
#579
Conversation
I don't understand why Document-CI is failing, |
Maybe |
MLUtils is a docs dependency and depends on FLoops - however FLoops does not support BangBang >= 0.4 currently. |
MLUtils is used in a single example: DynamicPPL.jl/docs/src/tutorials/prob-interface.md Lines 112 to 141 in abcf584
Since it's a quite heavy dependency, I wonder if we could avoid it. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Okay, the situation is a bit troublesome. |
Let's move to |
Pull Request Test Coverage Report for Build 8745141284Details
💛 - Coveralls |
In light of JuliaFolds2/BangBang.jl@e679bae, we can removed the code as they are implemented in BangBang.
The changes has not been released, so should verify afterward. And this PR should not be merged right now.
related: fix #530