Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subsume when checking for repeated varnames #602

Merged
merged 3 commits into from
May 10, 2024

Conversation

torfjelde
Copy link
Member

@sunxd3 pointed out that we should be using subsume rather than equality when checking whether a varname has been seen in the model already (TuringLang/Turing.jl#2218 (comment)).

This PR does exactly that.

@coveralls
Copy link

coveralls commented May 8, 2024

Pull Request Test Coverage Report for Build 9021828428

Details

  • 5 of 15 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 78.519%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/debug_utils.jl 5 15 33.33%
Totals Coverage Status
Change from base Build 8991588253: -0.2%
Covered Lines: 2789
Relevant Lines: 3552

💛 - Coveralls

@torfjelde
Copy link
Member Author

@sunxd3 @devmotion @yebai can one of you have a look at this? Should be a quick merge

@sunxd3
Copy link
Member

sunxd3 commented May 9, 2024

@torfjelde do you think is it worth it to add test for member test (e.g. a and a.b)? Otherwise, look good to me. Thanks for this.

@torfjelde torfjelde enabled auto-merge May 10, 2024 08:49
@torfjelde torfjelde added this pull request to the merge queue May 10, 2024
Merged via the queue into master with commit 6563e60 May 10, 2024
11 of 12 checks passed
@torfjelde torfjelde deleted the torfjelde/check-model-improvement branch May 10, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants