-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added back prob
and logprob
macros (but have them error)
#609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Pull Request Test Coverage Report for Build 9126744062Details
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #609 +/- ##
==========================================
- Coverage 76.93% 76.27% -0.66%
==========================================
Files 30 29 -1
Lines 3572 3439 -133
==========================================
- Hits 2748 2623 -125
+ Misses 824 816 -8 ☔ View full report in Codecov by Sentry. |
prob
and logprob
macrosprob
and logprob
macros (but have them error)
#604 removed these two macros, but this will just result in ambiguous errors for lots of users (this feature has been displayed in the Turing.jl docs and we know there are people using it) without telling them anything about why the changes was made.
This PR makes them instead error, providing some information on where to find discussion + how to "replace" some of its functionality.