Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointpriors #663

Merged
merged 39 commits into from
Sep 30, 2024
Merged

Pointpriors #663

merged 39 commits into from
Sep 30, 2024

Commits on Sep 16, 2024

  1. implement pointwise_logpriors

    @bgctw
    bgctw committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d05124c View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. implement varwise_logpriors

    @bgctw
    bgctw committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4f46102 View commit details
    Browse the repository at this point in the history

  2. remove pointwise_logpriors

    @bgctw
    bgctw committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c6653b9 View commit details
    Browse the repository at this point in the history

  3. revert dot_assume to not explicitly resolve components of sum

    @bgctw
    bgctw committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    216d50c View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. docstring varwise_logpriores 

    use loop for prior in example

Unfortunately cannot make it a jldoctest, because relies on Turing for sampling
    @bgctw
    bgctw committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fd8d3b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. integrate pointwise_loglikelihoods and varwise_logpriors by pointwise… 

    …_densities
    @bgctw
    bgctw committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5842656 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. record single prior components 

    by forwarding dot_tilde_assume to tilde_assume
    @bgctw
    bgctw committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    18beb57 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. forward dot_tilde_assume to tilde_assume for Multivariate

    @bgctw
    bgctw committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    d9945d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. avoid recording prior components on leaf-prior-context 

    and avoid recording likelihoods when invoked with leaf-Likelihood context
    @bgctw
    bgctw committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    656a757 View commit details
    Browse the repository at this point in the history

  2. undeprecate pointwise_loglikelihoods and implement pointwise_prior_lo… 

    …gdensities

mostly taken from TuringLang#669
    @bgctw
    bgctw committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7aa9ebe View commit details
    Browse the repository at this point in the history

  3. drop vi instead of re-compute vi 

    bgctw first forwared dot_tilde_assume to get a correct vi
and then recomputed it for recording component prior densities.

Replaced this by the Hack of torfjelde that completely drops vi and recombines the value, so that assume is called only once for each varName,
    @bgctw
    bgctw committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2f67c5b View commit details
    Browse the repository at this point in the history

  4. include docstrings of pointwise_logdensities 

    pointwise_prior_logdensities
int api.md docu
    @bgctw
    bgctw committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9dfb9ed View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Update src/pointwise_logdensities.jl remove commented code 

    Co-authored-by: Tor Erlend Fjelde <[email protected]>
    @bgctw @torfjelde
    bgctw and torfjelde authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c1939e0 View commit details
    Browse the repository at this point in the history

  2. Update src/pointwise_logdensities.jl remove commented code 

    Co-authored-by: Tor Erlend Fjelde <[email protected]>
    @bgctw @torfjelde
    bgctw and torfjelde authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    790be1d View commit details
    Browse the repository at this point in the history

  3. Update test/pointwise_logdensities.jl rename m to model 

    Co-authored-by: Tor Erlend Fjelde <[email protected]>
    @bgctw @torfjelde
    bgctw and torfjelde authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    426df38 View commit details
    Browse the repository at this point in the history

  4. Update test/pointwise_logdensities.jl remove unused code 

    Co-authored-by: Tor Erlend Fjelde <[email protected]>
    @bgctw @torfjelde
    bgctw and torfjelde authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c32bf3b View commit details
    Browse the repository at this point in the history

  5. Update test/pointwise_logdensities.jl rename m to model 

    Co-authored-by: Tor Erlend Fjelde <[email protected]>
    @bgctw @torfjelde
    bgctw and torfjelde authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6213249 View commit details
    Browse the repository at this point in the history

  6. Update test/pointwise_logdensities.jl rename m to model 

    Co-authored-by: Tor Erlend Fjelde <[email protected]>
    @bgctw @torfjelde
    bgctw and torfjelde authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3551b38 View commit details
    Browse the repository at this point in the history

  7. Update src/test_utils.jl remove old code 

    Co-authored-by: Tor Erlend Fjelde <[email protected]>
    @bgctw @torfjelde
    bgctw and torfjelde authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    95c892b View commit details
    Browse the repository at this point in the history

  8. rename m to model

    @bgctw
    bgctw committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a7a7e70 View commit details
    Browse the repository at this point in the history

  9. JuliaFormatter

    @bgctw
    bgctw committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1653aba View commit details
    Browse the repository at this point in the history

  10. Merge branch 'pointpriors' of github.com:bgctw/DynamicPPL.jl into poi… 

    …ntpriors
    @bgctw
    bgctw committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e4f0a1d View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Update test/runtests.jl remove interactive code 

    Co-authored-by: Tor Erlend Fjelde <[email protected]>
    @bgctw @torfjelde
    bgctw and torfjelde authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a99eab4 View commit details
    Browse the repository at this point in the history

  2. remove demo_dot_assume_matrix_dot_observe_matrix2 testcase 

    testing  higher dimensions better left for other  PR
    @bgctw
    bgctw committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    64ce63a View commit details
    Browse the repository at this point in the history

  3. ignore local interactive development code

    @bgctw
    bgctw committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    456115c View commit details
    Browse the repository at this point in the history

  4. ignore temporary directory holding local interactive development code

    @bgctw
    bgctw committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    222529a View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review: clean up comments and Imports 

    Co-authored-by: Tor Erlend Fjelde <[email protected]>
    @bgctw @torfjelde
    bgctw and torfjelde authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    17b251a View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review: change test of applying to chains… 

    … on already used model

Co-authored-by: Tor Erlend Fjelde <[email protected]>
    @bgctw @torfjelde
    bgctw and torfjelde authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7e990f0 View commit details
    Browse the repository at this point in the history

  7. fix test on names in likelihood components 

    to work with literal models
    @bgctw
    bgctw committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8706f68 View commit details
    Browse the repository at this point in the history

  8. try to fix testset pointwise_logdensities chain

    @bgctw
    bgctw committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    073a325 View commit details
    Browse the repository at this point in the history

  9. Update test/pointwise_logdensities.jl

    @torfjelde
    torfjelde authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    23e1711 View commit details
    Browse the repository at this point in the history

  10. Update .gitignore

    @torfjelde
    torfjelde authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    34ae4f8 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into pointpriors

    @torfjelde
    torfjelde authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1f251d1 View commit details
    Browse the repository at this point in the history

  12. Formtating

    @torfjelde
    torfjelde committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    777624a View commit details
    Browse the repository at this point in the history

  13. Fixed tests

    @torfjelde
    torfjelde committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4864e60 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Updated docs for pointwise_logdensities + made it a doctest not 

    dependent on Turing.jl
    @torfjelde
    torfjelde committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4d3b0c0 View commit details
    Browse the repository at this point in the history

  2. Bump patch version

    @torfjelde
    torfjelde committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e54fa4e View commit details
    Browse the repository at this point in the history

  3. Remove blank line from @model in doctest to see if that fixes the 

    parsing issues
    @torfjelde
    torfjelde committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    bcd82a9 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Added doctest filter to handle the ;;] at the end of lines for matr… 

    …ices
    @torfjelde
    torfjelde committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    cff0941 View commit details
    Browse the repository at this point in the history