initial_values: rename theta to flattened_param_vals

[vandenman]

Fixes #672

[coveralls]

Pull Request Test Coverage Report for Build 11049838323

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 77.486%

---

Totals
Change from base Build 10992907511:	0.0%
Covered Lines:	2712
Relevant Lines:	3500

---

💛 - Coveralls

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.22%. Comparing base (ad88334) to head (0a4e298).
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
- Coverage   75.93%   75.22%   -0.71%     
==========================================
  Files          29       29              
  Lines        3519     3266     -253     
==========================================
- Hits         2672     2457     -215     
+ Misses        847      809      -38     

Flag	Coverage Δ
	75.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[torfjelde]

Lovely! Thank you @vandenman!

Could you also add a test here:

DynamicPPL.jl/test/sampler.jl

Lines 160 to 164 in 0e40bd0

	# specify `initial_params=nothing`
	Random.seed!(1234)
	chain1 = sample(model, sampler, 1; progress=false)
	Random.seed!(1234)
	chain2 = sample(model, sampler, 1; initial_params=nothing, progress=false)

Should be sufficient to just add a line of the form

@test_throws DimensionMismatch sample(model, sampler, 1; progress=false, initial_params=zeros(10))

to make sure that we're correctly throwing an error in the case of incorrect lengths:)

Once that's done, I'll hit the big green button:)

(I would have made a Github suggestion but unfortunately can't do that to files that are not altered in the PR)

[vandenman]

@torfjelde no problem, let me know if there is anything else!

[torfjelde]

Lovely; thank you @vandenman !

There was a minor formatting issue that I just fixed 👍

Approved and scheduled it to "merge when ready" i.e. once test suite passes! Appreciate your contribution:)